szaszm commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1714362473
########## test_package/src/AbstractProcessorTest.cpp: ########## @@ -0,0 +1,114 @@ +/** Review Comment: I think we should run the same unit tests as we would run normally, even in a Conan build. I'm not a fan of duplicating a single test and introducing a new test package for conan builds, it adds too much maintenance burden. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
