fgerlits commented on code in PR #1994:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1994#discussion_r2251706659
##########
extensions/opc/src/fetchopc.cpp:
##########
@@ -140,7 +205,7 @@ bool FetchOPCProcessor::nodeFoundCallBack(const
UA_ReferenceDescription *ref, co
return true;
}
-void FetchOPCProcessor::OPCData2FlowFile(const opc::NodeData& opc_node,
core::ProcessContext&, core::ProcessSession& session) {
+void FetchOPCProcessor::OPCData2FlowFile(const opc::NodeData& opc_node,
core::ProcessContext&, core::ProcessSession& session, const std::string&
node_value) const {
Review Comment:
Is there a branch where we write anything other than
`opc::nodeValue2String(opc_node)`? I can't find one, so I don't understand the
reason for adding a new argument to the function.
##########
extensions/opc/src/fetchopc.cpp:
##########
@@ -107,30 +116,86 @@ void FetchOPCProcessor::onTrigger(core::ProcessContext&
context, core::ProcessSe
logger_->log_warn("Found no variables when traversing the specified node.
No flowfiles are generated. Yielding...");
yield();
}
+
+ state_manager_->set(state_map);
Review Comment:
Should this be in a `gsl::finally`? I.e., do we want to update the state if
the processing failed? I would guess yes, but I'm not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
