lordgamez commented on code in PR #1994:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1994#discussion_r2253779932
##########
extensions/opc/src/fetchopc.cpp:
##########
@@ -140,7 +205,7 @@ bool FetchOPCProcessor::nodeFoundCallBack(const
UA_ReferenceDescription *ref, co
return true;
}
-void FetchOPCProcessor::OPCData2FlowFile(const opc::NodeData& opc_node,
core::ProcessContext&, core::ProcessSession& session) {
+void FetchOPCProcessor::OPCData2FlowFile(const opc::NodeData& opc_node,
core::ProcessContext&, core::ProcessSession& session, const std::string&
node_value) const {
Review Comment:
It is just a minimal optimization in the
`writeFlowFileUsingLazyModeWithNewValue` function where we call the
`nodeValue2String` beforehand to check if the value is new opposed to the one
in the stored state, and if so we pass that to the `OPCData2FlowFile` instead
of calling the `opc::nodeValue2String` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
