fgerlits commented on code in PR #1994:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1994#discussion_r2253820077
##########
extensions/opc/src/fetchopc.cpp:
##########
@@ -140,7 +205,7 @@ bool FetchOPCProcessor::nodeFoundCallBack(const
UA_ReferenceDescription *ref, co
return true;
}
-void FetchOPCProcessor::OPCData2FlowFile(const opc::NodeData& opc_node,
core::ProcessContext&, core::ProcessSession& session) {
+void FetchOPCProcessor::OPCData2FlowFile(const opc::NodeData& opc_node,
core::ProcessContext&, core::ProcessSession& session, const std::string&
node_value) const {
Review Comment:
In my opinion all this extra code is not worth it for the very small
performance improvement (if any). We can keep it if you like it, but I would
remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
