lordgamez commented on code in PR #1994:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1994#discussion_r2253765429
##########
extensions/opc/src/fetchopc.cpp:
##########
@@ -107,30 +116,86 @@ void FetchOPCProcessor::onTrigger(core::ProcessContext&
context, core::ProcessSe
logger_->log_warn("Found no variables when traversing the specified node.
No flowfiles are generated. Yielding...");
yield();
}
+
+ state_manager_->set(state_map);
Review Comment:
In case there is an error we do not call the `traverse` in the onTrigger on
the OPC nodes, so we do not have any new when we return early, so I think there
is no need to update the state in this case. We also do not want to store
values that we did not write into a flowfile before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]