pvillard31 commented on code in PR #10670:
URL: https://github.com/apache/nifi/pull/10670#discussion_r2634324945
##########
nifi-extension-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java:
##########
Review Comment:
Should we also set the `driver` field in the happy path?
```suggestion
driver = DriverManager.getDriver(url);
return driver;
```
##########
nifi-extension-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java:
##########
@@ -272,4 +276,14 @@ protected Driver getDriver(final String driverName, final
String url) {
}
}
}
+
+ @OnRemoved
+ public void onRemove() {
Review Comment:
If we enable/disable the controller service many times, a new driver
instance might be created and registered, no? Should we have a similar logic
added in `@OnDisabled`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
