sfc-gh-rpaulin commented on PR #10670: URL: https://github.com/apache/nifi/pull/10670#issuecomment-3675400332
> Thanks for working on this improvement @bobpaulin. Does the same change need to be made to the HikariCP implementation? I could see that being handled in a separate issue if needed. I noticed HikariCP does not use the DriverManager to register the driver [1]. But on closer inspection this seems to indicate there might be a way for me to further improve on this code. Further while HikariCP does not use the DriverManager to register there are many places [2] in NiFi that do. Each need to be looked at each independently based as depending on Instance vs Shared Classloading might require different remedies. I agree independent issues is the way to address this. [1] https://github.com/brettwooldridge/HikariCP/blob/bba167f0a28905e8e63083cd7b5cbf479263271a/src/main/java/com/zaxxer/hikari/util/DriverDataSource.java#L65 [2] https://github.com/search?q=repo%3Aapache%2Fnifi%20DriverManager.register&type=code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
