bobpaulin commented on code in PR #10670: URL: https://github.com/apache/nifi/pull/10670#discussion_r2635183486
########## nifi-extension-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java: ########## Review Comment: This is an excellent question. We do not since this only for holding a driver the was instantiated within the controller service. We should not be tracking and unregistering a driver that was not instantiated here. The answer is not intuitive so I've updated the code to make the intent more obvious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
