bobpaulin commented on code in PR #10670:
URL: https://github.com/apache/nifi/pull/10670#discussion_r2635191186
##########
nifi-extension-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java:
##########
@@ -272,4 +276,14 @@ protected Driver getDriver(final String driverName, final
String url) {
}
}
}
+
+ @OnRemoved
+ public void onRemove() {
Review Comment:
I do not think we need to do this since if the driver is already loaded from
a previous enable we should not need to reload it unless it has changed. But
this raises an important point that I've addressed in a different way where if
the registeredDriver is not null we deregister it before registering a new one
to replace it. I think this should address the above concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
