markap14 commented on PR #11240: URL: https://github.com/apache/nifi/pull/11240#issuecomment-5025085197
[Sonnet 5] @ncover21 good catch, thanks. Confirmed the bug: `configurationDiffersFromDefaults` treated any non-`StringLiteralValue` reference as a modification, including a structurally-empty `SecretReference` or `AssetReference` — exactly the placeholder-for-unset-property shape the framework already special-cases elsewhere (`isEmptySecretReference`, `isReferenceAllowed`). Reproduced the failure with a unit test that seeds an empty `SecretReference`/`AssetReference` and asserts `isModified()` returns `false`, confirmed it failed as described, then fixed `configurationDiffersFromDefaults` to skip structurally-empty typed references, and added a test confirming a *populated* `AssetReference` is still correctly treated as a modification. Pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
