markap14 commented on PR #11240: URL: https://github.com/apache/nifi/pull/11240#issuecomment-5027408760
[Sonnet 5] @ncover21 confirmed, thanks — good catch again. \`notifyMigrationComplete(...)\` only called the \`migrationComplete(...)\` hook, unlike \`configureConnector(...)\`/\`updateConnector(...)\` which always \`save(...)\` after a change. Reproduced with a unit test asserting \`provider.save(...)\` is invoked after \`notifyMigrationComplete(...)\`, confirmed it failed (save was never called), then added the save using the exact approach you suggested — \`buildWorkingConfiguration(connector)\`, which reflects the merged configuration since \`commitMigratedConfiguration(...)\` already rebuilt the working flow context from it before this runs. Pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
