Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137864284
--- Diff: libminifi/include/core/Processor.h ---
@@ -212,19 +217,35 @@ class Processor : public Connectable, public
ConfigurableComponent, public std::
public:
// OnTrigger method, implemented by NiFi Processor Designer
+ virtual void onTrigger(std::shared_ptr<ProcessContext> context,
std::shared_ptr<ProcessSession> session){
+ onTrigger(context.get(),session.get());
+ }
virtual void onTrigger(ProcessContext *context, ProcessSession *session)
= 0;
// Initialize, overridden by NiFi Process Designer
virtual void initialize() {
}
// Scheduled event hook, overridden by NiFi Process Designer
+ virtual void onSchedule(std::shared_ptr<ProcessContext> context,
std::shared_ptr<ProcessSessionFactory> sessionFactory){
+ onSchedule(context.get(),sessionFactory.get());
+ }
virtual void onSchedule(ProcessContext *context, ProcessSessionFactory
*sessionFactory) {
}
// Check all incoming connections for work
bool isWorkAvailable();
+ void setStreamFactory(std::shared_ptr<minifi::io::StreamFactory>
stream_factory) {
--- End diff --
Why not just require a valid StreamFactory when the object is constructed,
and not allow it to be dynamically changed?
---
