Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/118#discussion_r176271235
  
    --- Diff: 
minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/FlowStatus.java
 ---
    @@ -0,0 +1,51 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.c2.model;
    +
    +import io.swagger.annotations.ApiModel;
    +import io.swagger.annotations.ApiModelProperty;
    +
    +import java.util.Map;
    +
    +/**
    + * Status of the aspects of the flow that are controllable by the C2 
server, ie:
    + *   - Processors that can be started/stopped and their current state
    + *   - Queues that can be cleared and their current state
    + */
    +@ApiModel
    +public class FlowStatus {
    --- End diff --
    
    Perhaps it is the naming, but the name  FlowComponentStatus implies that it 
is part of the flow, but there may be components that run that are flow 
independent. For example think of things that may run a procedure. That 
component could be tracked in the FlowComponentStatus map components, but 
perhaps not. 
    
    Additionally, not sure I mentioned this already but I see that tracking 
maps are not concurrent map impls. Should I assume that state is 
monitored/controlled elsewhere? 


---

Reply via email to