Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/118#discussion_r176273652
  
    --- Diff: 
minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/ExtensionComponent.java
 ---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.c2.model.extension;
    +
    +import io.swagger.annotations.ApiModel;
    +import io.swagger.annotations.ApiModelProperty;
    +
    +import java.util.List;
    +import java.util.Set;
    +
    +/**
    + * A component provided by an extension bundle
    + */
    +@ApiModel
    +public class ExtensionComponent extends DefinedType {
    +
    +    // TODO, does arch/binary/compiler metadata need to be added here?
    --- End diff --
    
    There may be additional toolchain formation we may need to carry over. I'm 
not 100% certain at this time if we would need all of that. It comes down to 
making a decision based on the compile time flags to know if an extension or 
implementation of an extension is translatable to an agent's architecture. I'm 
a little fuzzy on how this model views ExtensionComponent as it relates to an 
Extension of architectures types. In that case would it make this an 
implementation of N types of components based on flags/architectures or a 
singular object which is encapsulated elsewhere, with the necessary 
information...


---

Reply via email to