Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/118#discussion_r176272024
  
    --- Diff: 
minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/ExtensionComponent.java
 ---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.minifi.c2.model.extension;
    +
    +import io.swagger.annotations.ApiModel;
    +import io.swagger.annotations.ApiModelProperty;
    +
    +import java.util.List;
    +import java.util.Set;
    +
    +/**
    + * A component provided by an extension bundle
    + */
    +@ApiModel
    +public class ExtensionComponent extends DefinedType {
    +
    +    // TODO, does arch/binary/compiler metadata need to be added here?
    --- End diff --
    
    For extensions we probably need to carry the type of built binary, to 
include arch built, compiler flags that could limit cross platform 
compatibility, and anything else that could possibly limit movement of that 
object. Ideally this is all abstracted from the user, so whether that lives 
here or elsewhere is unclear; however we would need to be certain a user isn't 
getting x86 shared object when they're running on a pi. 


---

Reply via email to