[ 
https://issues.apache.org/jira/browse/MINIFICPP-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431523#comment-16431523
 ] 

ASF GitHub Bot commented on MINIFICPP-449:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180264480
  
    --- Diff: CMakeLists.txt ---
    @@ -117,6 +118,49 @@ else ()
       message( FATAL_ERROR "OpenSSL was not found. Please install OpenSSL" )
     endif (OPENSSL_FOUND)
     
    +if(NOT USE_SYSTEM_CURL)
    --- End diff --
    
    This should be in http-curl. If curl is disabled there is no point in 
adding it as an external project


> Allow cURL to be built and statically linked
> --------------------------------------------
>
>                 Key: MINIFICPP-449
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-449
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> Allowing cURL to be built as an external project and linked statically will 
> help support certain embedded deployments and certain portability situations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to