[
https://issues.apache.org/jira/browse/MINIFICPP-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432719#comment-16432719
]
ASF GitHub Bot commented on MINIFICPP-449:
------------------------------------------
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180521508
--- Diff: extensions/http-curl/CMakeLists.txt ---
@@ -42,9 +42,9 @@ if(CMAKE_THREAD_LIBS_INIT)
endif()
if (CURL_FOUND)
- include_directories(${CURL_INCLUDE_DIRS})
- target_link_libraries (minifi-http-curl ${CURL_LIBRARIES})
-endif(CURL_FOUND)
+ include_directories(${CURL_INCLUDE_DIRS})
+ target_link_libraries(minifi-http-curl ${CURL_LIBRARIES})
--- End diff --
Agreed that we should have the option to static link when not using
bundled. I think that should be done in a new ticket that covers all dynamic
libs that have static linking options when linking system libs, possibly with a
general option e.g. STATIC_LINK_ALL.
> Allow cURL to be built and statically linked
> --------------------------------------------
>
> Key: MINIFICPP-449
> URL: https://issues.apache.org/jira/browse/MINIFICPP-449
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> Allowing cURL to be built as an external project and linked statically will
> help support certain embedded deployments and certain portability situations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
