[
https://issues.apache.org/jira/browse/MINIFICPP-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431533#comment-16431533
]
ASF GitHub Bot commented on MINIFICPP-449:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180264700
--- Diff: main/CMakeLists.txt ---
@@ -66,7 +66,7 @@ else ()
target_link_libraries (minifiexe -Wl,--whole-archive minifi
-Wl,--no-whole-archive)
endif ()
-target_link_libraries(minifiexe yaml-cpp ${UUID_LIBRARIES}
${OPENSSL_LIBRARIES})
+target_link_libraries(minifiexe yaml-cpp ${UUID_LIBRARIES}
${CURL_LIBRARIES} ${OPENSSL_LIBRARIES})
--- End diff --
This should not be included here. It should be passed transitively through
the minifi-http-curl iff it is enabled.
> Allow cURL to be built and statically linked
> --------------------------------------------
>
> Key: MINIFICPP-449
> URL: https://issues.apache.org/jira/browse/MINIFICPP-449
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> Allowing cURL to be built as an external project and linked statically will
> help support certain embedded deployments and certain portability situations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
