[
https://issues.apache.org/jira/browse/MINIFICPP-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431532#comment-16431532
]
ASF GitHub Bot commented on MINIFICPP-449:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180265512
--- Diff: extensions/http-curl/CMakeLists.txt ---
@@ -42,9 +42,9 @@ if(CMAKE_THREAD_LIBS_INIT)
endif()
if (CURL_FOUND)
- include_directories(${CURL_INCLUDE_DIRS})
- target_link_libraries (minifi-http-curl ${CURL_LIBRARIES})
-endif(CURL_FOUND)
+ include_directories(${CURL_INCLUDE_DIRS})
+ target_link_libraries(minifi-http-curl ${CURL_LIBRARIES})
--- End diff --
^ Even in the case of a system library we could rely on the static library
if it exists. We don't do it now to ensure we have a small binary size, but we
should make it clear that while downloading the source and building manually is
an option in most cases a static curl lib likely already exists on the build
system. In my case I've just checked my centos 7,6, u16-18, fedora, and suse
VMs and they all have static libs. There should be a little work here to ensure
we get that IF the user wants that. Perhaps that necessitates an added option?
> Allow cURL to be built and statically linked
> --------------------------------------------
>
> Key: MINIFICPP-449
> URL: https://issues.apache.org/jira/browse/MINIFICPP-449
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> Allowing cURL to be built as an external project and linked statically will
> help support certain embedded deployments and certain portability situations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
