Github user zenfenan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2751#discussion_r194009531
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
 ---
    @@ -307,6 +328,20 @@ private boolean commit(final ProcessContext context, 
final ProcessSession sessio
             return willCommit;
         }
     
    +    private Map<String, String> writeObjectTags(AmazonS3 client, 
S3VersionSummary versionSummary) {
    +        final GetObjectTaggingResult taggingResult = 
client.getObjectTagging(new 
GetObjectTaggingRequest(versionSummary.getBucketName(), 
versionSummary.getKey()));
    --- End diff --
    
    Yep. It'll make additional API call but I don't think it will have any 
negative impact on the existing flows? Do you sense any cases where this might 
break? This simply calls S3 service to see if this key has any tags associated, 
if it has, it will add to the flowfile attributes.


---

Reply via email to