Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2751#discussion_r193976840
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
---
@@ -307,6 +328,20 @@ private boolean commit(final ProcessContext context,
final ProcessSession sessio
return willCommit;
}
+ private Map<String, String> writeObjectTags(AmazonS3 client,
S3VersionSummary versionSummary) {
+ final GetObjectTaggingResult taggingResult =
client.getObjectTagging(new
GetObjectTaggingRequest(versionSummary.getBucketName(),
versionSummary.getKey()));
--- End diff --
Can't have a deeper look right now but is the retrieval of tags requiring
an additional call to the API or is the info already retrieved anyway? If this
line causes an additional call to the API, I'd recommend to change the default
value of the property to "false" so that existing/running workflows are not
impacted by this change. Thoughts?
---
