Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2751#discussion_r195169135
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
 ---
    @@ -205,11 +210,21 @@
                 .defaultValue(NO_SERVER_SIDE_ENCRYPTION)
                 .build();
     
    +    public static final PropertyDescriptor OBJECT_TAGS = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    I completely agree that the same result can be achieved with both options. 
It's just that ExecuteScript will require someone to write some lines of code. 
Also, I'm not a big fan of the idea to have a big JSON document as a flow file 
attribute but I don't expect someone to define hundreds of tags. Anyway, I'm ok 
to merge as-is, I can do it once the other comment is addressed. Thanks!


---

Reply via email to