Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2751#discussion_r194033825
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
---
@@ -307,6 +328,20 @@ private boolean commit(final ProcessContext context,
final ProcessSession sessio
return willCommit;
}
+ private Map<String, String> writeObjectTags(AmazonS3 client,
S3VersionSummary versionSummary) {
+ final GetObjectTaggingResult taggingResult =
client.getObjectTagging(new
GetObjectTaggingRequest(versionSummary.getBucketName(),
versionSummary.getKey()));
--- End diff --
I just imagine the case where a user is listing a lot of objects in S3 and
this could cause a large amount of additional calls. I agree that the overhead
should be fairly limited. Just wondering if we want this new behavior to be
enabled by default. I honestly don't have any strong opinion on that, just
wanted to mention it. Do you have an opinion on that @jvwing ?
---
