[
https://issues.apache.org/jira/browse/MINIFICPP-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667511#comment-16667511
]
ASF GitHub Bot commented on MINIFICPP-654:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229015052
--- Diff: libminifi/include/capi/Plan.h ---
@@ -16,6 +16,8 @@
* limitations under the License.
*/
+#pragma once
--- End diff --
The more I think about this for a public, open source project, we should
probably avoid pragma once given that it's implementation defined and not
language spec. We don't control all compiler variants, especially for what will
be this portion of the API. I realize it's nearly "universally supported" but
it seems like an unnecessary risk, albeit small.
> C API: failure callback improvements
> ------------------------------------
>
> Key: MINIFICPP-654
> URL: https://issues.apache.org/jira/browse/MINIFICPP-654
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Minor
> Fix For: 0.6.0
>
>
> Improvements and further discussion of failure callbacks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
