[
https://issues.apache.org/jira/browse/MINIFICPP-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667508#comment-16667508
]
ASF GitHub Bot commented on MINIFICPP-654:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229017394
--- Diff: libminifi/include/capi/Plan.h ---
@@ -46,11 +48,50 @@
#include "capi/cstructs.h"
#include "capi/api.h"
+enum FailureStrategy { AS_IS, ROLLBACK };
+
+bool intToFailureStragey(int in, FailureStrategy *out);
+
+using callback_type = std::function<void(flow_file_record*)>;
--- End diff --
^I'm not inherently against aliasing but I think 'callback_type' does
little to improve readability, and since readability is in the eye of the
beholder ( and I don't have a preference if others use it ) is there a way to
at least better indicate that this is a function used for a certain type of
callback?
> C API: failure callback improvements
> ------------------------------------
>
> Key: MINIFICPP-654
> URL: https://issues.apache.org/jira/browse/MINIFICPP-654
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Minor
> Fix For: 0.6.0
>
>
> Improvements and further discussion of failure callbacks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
