[ 
https://issues.apache.org/jira/browse/MINIFICPP-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667787#comment-16667787
 ] 

ASF GitHub Bot commented on MINIFICPP-654:
------------------------------------------

Github user arpadboda commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229108728
  
    --- Diff: libminifi/src/capi/api.cpp ---
    @@ -400,11 +395,19 @@ processor *add_processor_with_linkage(flow *flow, 
const char *processor_name) {
       return nullptr;
     }
     
    -int add_failure_callback(flow *flow, void (*onerror_callback)(const 
flow_file_record*)) {
    +int add_failure_callback(flow *flow, void 
(*onerror_callback)(flow_file_record*)) {
       ExecutionPlan *plan = static_cast<ExecutionPlan*>(flow->plan);
       return plan->setFailureCallback(onerror_callback) ? 0 : 1;
     }
     
    +int set_failure_strategy(flow *flow, int strategy) {
    --- End diff --
    
    The reason is pretty simple: I didn't have enough coffee when I wrote this, 
so forgot that C also supports enums. :) Will replace. 


> C API: failure callback improvements
> ------------------------------------
>
>                 Key: MINIFICPP-654
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-654
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Arpad Boda
>            Assignee: Arpad Boda
>            Priority: Minor
>             Fix For: 0.6.0
>
>
> Improvements and further discussion of failure callbacks. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to