[
https://issues.apache.org/jira/browse/MINIFICPP-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667786#comment-16667786
]
ASF GitHub Bot commented on MINIFICPP-654:
------------------------------------------
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229108406
--- Diff: libminifi/src/capi/api.cpp ---
@@ -170,31 +165,31 @@ flow_file_record* create_ff_object_na(const char
*file, const size_t len, const
new_ff->attributes = nullptr;
new_ff->contentLocation = new char[len + 1];
snprintf(new_ff->contentLocation, len + 1, "%s", file);
- std::ifstream in(file, std::ifstream::ate | std::ifstream::binary);
// set the size of the flow file.
new_ff->size = size;
+ new_ff->crp = static_cast<void*>(new
std::shared_ptr<minifi::core::ContentRepository>);
--- End diff --
As there are no arguments provided, I couldn't save specifying the template
parameter. Moreover it's an empty shared ptr, so it doesn't even allocate
twice.
> C API: failure callback improvements
> ------------------------------------
>
> Key: MINIFICPP-654
> URL: https://issues.apache.org/jira/browse/MINIFICPP-654
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Minor
> Fix For: 0.6.0
>
>
> Improvements and further discussion of failure callbacks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
