Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234007116
--- Diff: libminifi/include/io/CRCStream.h ---
@@ -194,15 +194,12 @@ int CRCStream<T>::readData(uint8_t *buf, int buflen) {
}
template<typename T>
-int CRCStream<T>::writeData(std::vector<uint8_t> &buf, int buflen) {
-
- if ((int)buf.capacity() < buflen)
--- End diff --
This existed for a reason. Did you test this in flight ? This causes a
failure. We have non const because we reserve the right to adjust buffers.
That's the intent behind making the signatures the way they are.
---
