Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234009476
--- Diff: libminifi/src/io/FileStream.cpp ---
@@ -82,16 +82,16 @@ void FileStream::seek(uint64_t offset) {
file_stream_->seekp(offset_);
}
-int FileStream::writeData(std::vector<uint8_t> &buf, int buflen) {
+int FileStream::writeData(const std::vector<uint8_t> &buf, int buflen) {
if (static_cast<int>(buf.capacity()) < buflen) {
return -1;
}
- return writeData(reinterpret_cast<uint8_t *>(&buf[0]), buflen);
--- End diff --
fails to compile on some of my archs. perhaps run make docker ?
---