Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234009236
--- Diff: libminifi/include/io/tls/TLSSocket.h ---
@@ -173,19 +173,19 @@ class TLSSocket : public Socket {
* @param buflen buffer to write
*
*/
- int writeData(std::vector<uint8_t> &buf, int buflen);
+ int writeData(const std::vector<uint8_t> &buf, int buflen);
--- End diff --
if we chose ( and we eventually will in further tickets ) to take this
memory and do a memmove ( in a different stream -- can discuss later ) we can't
do that with the changes. This was intentional and not an oversight.
---
