Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234176325
--- Diff: libminifi/include/io/Serializable.h ---
@@ -22,11 +22,36 @@
#include <string>
#include "EndianCheck.h"
#include "DataStream.h"
+
+namespace {
+ template<typename Integral, typename std::enable_if<
--- End diff --
You are right in the part that this doesn't improve either performance or
readibility.
This change became useful in the template write(Integral) function, where
this can be called easily, so I don't need to copy-paste writeData calls and
could remove the local template writeData implementation.
Overall I see more gain here.
---
