[
https://issues.apache.org/jira/browse/MINIFICPP-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858211#comment-16858211
]
Mr TheSegfault edited comment on MINIFICPP-910 at 6/7/19 2:46 AM:
------------------------------------------------------------------
Good stuff, I can imagine things like this popping up as more code is added.
Much like commons lang StringUtils, these needs will evolve, so providing
something like this as the needs arise is great.
Correct me if I'm wrong, but there is no immediate use of this...I'm struggling
to see why this was done in 0.7.0 versus many other bugs and immediate help
that we need.
was (Author: phrocker):
Good stuff! I'm in favor of discussing this for inclusion in 0.8.0 or 0.9.0
given we have an expectation of release in the next few months.
Sorry I didn't submit the edit, so this is a little late in coming as an edit–
so I'll add a little bit more detail.
To clarify, if there is a pressing need, as in this is directly used in PRs (
in fact I"d prefer to see it piggy backed onto those PRs ). It seems like a
utility function that needs to be tested has demonstrated failure on target
devices in certain modes ( though succeeds on some ), and isn't being used
doesn't warrant inclusion into the current release (I'd like to kick a release
out in the next month and a half if possible ); however, I think if you can
address those problems, the linking issues, and have a demonstrable need for it
then 0.7.0 is fair game. Otherwise it seems rather unnecessary to be included
into core.
> Extend StringUtils with string join capability
> ----------------------------------------------
>
> Key: MINIFICPP-910
> URL: https://issues.apache.org/jira/browse/MINIFICPP-910
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Major
> Fix For: 0.7.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> String join is frequently needed and MiNiFi code contains a lot of
> copy-pasted implementations for that. A general solution should be provided.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
