[
https://issues.apache.org/jira/browse/MINIFICPP-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858498#comment-16858498
]
Arpad Boda edited comment on MINIFICPP-910 at 6/7/19 10:57 AM:
---------------------------------------------------------------
Thinking a bit more while having my coffee, I found that the risk of this
change is pretty low.
I didn't change the implementation of the existing functions, just moved them
from a class to a namespace. Which naturally changes linkage, so we should
verify on target platforms, but the behaviour doesn't change, so in case it
compiles and loads all extensions, it should be ok.
was (Author: aboda):
Thinking a bit more while having my coffee, I found that the risk of this
change is pretty low.
I didn't change the implementation of the existing functions, just moved them
from a class to a namespace. Which naturally changes linkage, so we should
verify on target platforms, but the behaviour doesn't change, so in case it
compiles it should be ok.
> Extend StringUtils with string join capability
> ----------------------------------------------
>
> Key: MINIFICPP-910
> URL: https://issues.apache.org/jira/browse/MINIFICPP-910
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Major
> Fix For: 0.7.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> String join is frequently needed and MiNiFi code contains a lot of
> copy-pasted implementations for that. A general solution should be provided.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
