[
https://issues.apache.org/jira/browse/MINIFICPP-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858211#comment-16858211
]
Mr TheSegfault edited comment on MINIFICPP-910 at 6/7/19 2:49 AM:
------------------------------------------------------------------
Good stuff, I can imagine things like this popping up as more code is
added..much like commons lang StringUtils. These needs will evolve, so
providing something like this as the needs arise is great.
Correct me if I'm wrong, but there is no immediate use of this...I'm struggling
to see why this was done for 0.7.0 versus bugs and test infrastructure
improvements. I tend to scrutinize changes in libminifi more and build on other
platforms...there are also build issues across those, so it may help the PR to
minimize the necessary changes and show a need for it on something other than
changing existing code to validate its existence.
Sorry for the edits, trying to clarify my thoughts and not come across the
wrong way.
was (Author: phrocker):
Good stuff, I can imagine things like this popping up as more code is added.
Much like commons lang StringUtils, these needs will evolve, so providing
something like this as the needs arise is great.
Correct me if I'm wrong, but there is no immediate use of this...I'm struggling
to see why this was done in 0.7.0 versus many other bugs and immediate help
that we need. I tend to scrutinize changes in libminifi more and build on other
platforms...there are also build issues across those, so it may help the PR to
minimize the necessary changes and show a need for it.
> Extend StringUtils with string join capability
> ----------------------------------------------
>
> Key: MINIFICPP-910
> URL: https://issues.apache.org/jira/browse/MINIFICPP-910
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Major
> Fix For: 0.7.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> String join is frequently needed and MiNiFi code contains a lot of
> copy-pasted implementations for that. A general solution should be provided.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
