[
https://issues.apache.org/jira/browse/MINIFICPP-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858211#comment-16858211
]
Mr TheSegfault edited comment on MINIFICPP-910 at 6/7/19 3:41 AM:
------------------------------------------------------------------
Good stuff, I can imagine things like this popping up as more code is
added..much like commons lang StringUtils. These needs will evolve, so
providing something like this as the needs arise is great.
Correct me if I'm wrong, but there is no immediate use of this...I'm struggling
to see why this was done for 0.7.0 versus bugs and test infrastructure
improvements – but I definitely don't want to suppress creativity, so let's
look at how we can +1 this as the work has already been done.
I tend to scrutinize changes in libminifi more and build on other
platforms...there are also build issues across those, so it may help the PR to
minimize the necessary changes or address those problems and show a need for it
on something other than changing existing code to validate its existence. I'm
sure you have an emerging need, so perhaps piggyback this PR on to that? Happy
to +1 and merge with those issues addressed.
Thanks, good work!
Sorry for the million edits, trying to clarify my thoughts from my phone – so I
finally realized it keeps auto saving when the screen turns off.
was (Author: phrocker):
Good stuff, I can imagine things like this popping up as more code is
added..much like commons lang StringUtils. These needs will evolve, so
providing something like this as the needs arise is great.
Correct me if I'm wrong, but there is no immediate use of this...I'm struggling
to see why this was done for 0.7.0 versus bugs and test infrastructure
improvements. I tend to scrutinize changes in libminifi more and build on other
platforms...there are also build issues across those, so it may help the PR to
minimize the necessary changes and show a need for it on something other than
changing existing code to validate its existence.
Sorry for the edits, trying to clarify my thoughts and not come across the
wrong way.
> Extend StringUtils with string join capability
> ----------------------------------------------
>
> Key: MINIFICPP-910
> URL: https://issues.apache.org/jira/browse/MINIFICPP-910
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Major
> Fix For: 0.7.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> String join is frequently needed and MiNiFi code contains a lot of
> copy-pasted implementations for that. A general solution should be provided.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
