bakaid commented on a change in pull request #596: MINIFICPP-925 - Fix TailFile hang on long lines URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r296875257
########## File path: libminifi/src/utils/StringUtils.cpp ########## @@ -0,0 +1,162 @@ +/** Review comment: A cpp file was created because constexpr static members were added to the StringUtils class which necessitated it. Because it was created I made the trivial change of moving the functions I could to the cpp file, but that is not necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
