bakaid commented on a change in pull request #596: MINIFICPP-925 - Fix TailFile
hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r296876452
##########
File path: extensions/standard-processors/processors/HashContent.h
##########
@@ -38,21 +38,13 @@
#include "core/ProcessSession.h"
#include "core/Resource.h"
#include "io/BaseStream.h"
+#include "utils/StringUtils.h"
using HashReturnType = std::pair<std::string, int64_t>;
namespace {
#define HASH_BUFFER_SIZE 16384
- std::string digestToString(const unsigned char * const digest, size_t size) {
Review comment:
Yes, both in exizsting known answer tests in
https://github.com/apache/nifi-minifi-cpp/blob/master/extensions/standard-processors/tests/unit/HashContentTest.cpp#L50
and there are unit tests for uppercase hexencoding in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
