bakaid commented on a change in pull request #596: MINIFICPP-925 - Fix TailFile
hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r297579374
##########
File path: libminifi/test/pcap-tests/CMakeLists.txt
##########
@@ -29,17 +29,17 @@ FOREACH(testfile ${PCAP_TESTS})
target_include_directories(${testfilename} PRIVATE BEFORE
"${CMAKE_BINARY_DIR}/extensions/pcap/pcap++/Dist/header/")
createTests("${testfilename}")
if(APPLE)
- target_link_libraries ("${testfilename}" -Wl,-all_load minifi-pcap )
Review comment:
Thanks. The pcap tests now compile, but still not succeed my macOS, but I
will open a ticket for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
