bakaid commented on a change in pull request #596: MINIFICPP-925 - Fix TailFile
hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r296899784
##########
File path: extensions/standard-processors/processors/TailFile.cpp
##########
@@ -66,7 +66,8 @@ core::Property TailFile::StateFile("State File", "Specifies
the file that should
" what data has been ingested so that upon
restart NiFi can resume from where it left off",
"TailFileState");
core::Property TailFile::Delimiter("Input Delimiter", "Specifies the character
that should be used for delimiting the data being tailed"
Review comment:
I agree, I just did not want to include that in this PR, because that would
modify the behaviour of the processor in a way that could not be made
backward-compatible with default values.
Currently empty Delimiter means size-based without a size limit, and a
non-empty Delimiter means delimiter mode.
If we add a mode property, and make the default of that property the
delimiter mode, we would be backward-compatible with the current delimiter
mode, but break the non-delimiter mode.
If the default of that property is size-based mode, and the default size is
0 (unlimited), we keep compatibility with the non-delimiter mode, but break
compatibility with the delimiter mode.
I think it is a necessary move to make, but I do not know how such a change
(that would require configuration changes on update) can be made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
