phrocker commented on a change in pull request #595: Add windows tests URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r297094615
########## File path: extensions/http-curl/tests/TestServer.h ########## @@ -64,10 +68,47 @@ CivetServer * start_webserver(std::string &port, std::string &rooturi, CivetHand } +/** +This funciton, unfortunately, assumes that we're parsing http components of a local host. On windows this is problematic Review comment: typo in comment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
