phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r297094474
##########
File path: extensions/http-curl/tests/TestServer.h
##########
@@ -64,10 +68,47 @@ CivetServer * start_webserver(std::string &port,
std::string &rooturi, CivetHand
}
+/**
+This funciton, unfortunately, assumes that we're parsing http components of a
local host. On windows this is problematic
+so we convert localhost to our local hostname.
+ */
bool parse_http_components(const std::string &url, std::string &port,
std::string &scheme, std::string &path) {
- regex_t regex;
- const char *regexstr = "^(http|https)://(localhost:)([0-9]+)?(/.*)$";
+#if (__cplusplus > 201103L) || defined(_WIN32)
Review comment:
mixing of _win32 and win32 seems awkward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
