phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r297095126
##########
File path: libminifi/test/sqlite-tests/SQLiteTests.cpp
##########
@@ -55,7 +55,7 @@ TEST_CASE("Test Put", "[PutSQLPut]") { // NOLINT
// Define directory for test db
std::string test_dir("/tmp/gt.XXXXXX");
- REQUIRE(testController.createTempDirectory(&test_dir[0]) != nullptr);
+ REQUIRE(!testController.createTempDirectory(&test_dir[0]).empty());
Review comment:
should make a follow on for this extension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
