bakaid commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378752297
##########
File path: libminifi/src/c2/C2Agent.cpp
##########
@@ -506,13 +527,16 @@ void C2Agent::handle_describe(const C2ContentResponse
&resp) {
}
std::vector<std::shared_ptr<state::response::ResponseNode>> metrics_vec;
-
- reporter->getResponseNodes(metrics_vec, metric_class_id);
C2Payload response(Operation::ACKNOWLEDGE, resp.ident, false, true);
response.setLabel("metrics");
+
+ C2Payload metrics(Operation::ACKNOWLEDGE, resp.ident, false, true);
Review comment:
Why are two layers of `C2Payload` needed with the same label? "jstack" has
only one to which the children containing the real data is added.
"configuration" is rewritten here to have a "configurationOptions" node to
which an other "configurationOptions" node is added to which the children are
added.
"manifest" is written with the same extra layer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
