bakaid commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378755472
##########
File path: libminifi/src/c2/C2Agent.cpp
##########
@@ -539,9 +563,9 @@ void C2Agent::handle_describe(const C2ContentResponse
&resp) {
} else if (resp.name == "manifest") {
auto keys = configuration_->getConfiguredKeys();
Review comment:
This, unlike the "configuration" branch does not sanitize the keys. Isn't
this an issue?
(Also, if this is this way because of a mistake, removing the code
duplication between the two should prevent such things happening.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
