szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378835854
##########
File path: libminifi/include/core/state/nodes/AgentInformation.h
##########
@@ -623,18 +632,70 @@ class AgentManifest : public DeviceInformation {
};
/**
- * Purpose and Justification: Prints classes along with their properties for
the current agent.
+ * This class is used for regular heartbeat without manifest
+ * A light weight heartbeat
*/
-class AgentInformation : public DeviceInformation, public AgentMonitor, public
AgentIdentifier {
+class AgentInformationWithoutManifest : public DeviceInformation, public
AgentMonitor, public AgentIdentifier {
Review comment:
"agent information (without manifest) is a device information"
"agent information (without manifest) is an agent monitor"
"agent information (without manifest) in an agent identifier"
None of the above statements sound true, although I'm not sure about the
first one.
In the meantime I realized that this relationship was not introduced now but
taken over from old `AgentInformation`, so I'm fine with not changing the
design.
Thanks for the explanation why it cannot be a free function. Feel free to
mark this resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
