phrocker commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378842597
########## File path: libminifi/include/core/state/nodes/AgentInformation.h ########## @@ -623,18 +632,70 @@ class AgentManifest : public DeviceInformation { }; /** - * Purpose and Justification: Prints classes along with their properties for the current agent. + * This class is used for regular heartbeat without manifest + * A light weight heartbeat */ -class AgentInformation : public DeviceInformation, public AgentMonitor, public AgentIdentifier { +class AgentInformationWithoutManifest : public DeviceInformation, public AgentMonitor, public AgentIdentifier { Review comment: I just happened to see this E-mail and I think this is spot on. This evolved poorly and AgentInformation became more of a compositional relationship with these other artifacts as they changed in name and purpose. This should be improved at some point for maintainability. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services