msharee9 edited a comment on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#issuecomment-585918005 > > > @msharee9 Could you have a different endpoint that is used for a full posting and then another endpoint for a lightweight HB. The period for those could be different or the full posting could be sent only once ( with success validation ). > > > Another alternative is to have the C2 server request a full posting and then the registration occur in that case and otherwise always be a light weight HB. That may alleviate some of the complexity per @arpadboda > > > > > > The full posting is done only once in this code change and that is during C2 initialization and after that it is lightweight both going to the same endpoint though. I don't think it would work best from C2 server standpoint if we want to send to two different endpoints. > > Sending the full heartbeat with manifest during initialization is an optimization (thanks to @szaszm suggestion), otherwise, the original idea was to only send manifest when C2 server requests for it in DESCRIBE. > > In case the first heavyweight heartbeat is lost due to some reason, the C2 server will request manifest anyhow upon first successful reception of lightweight heartbeat. > > I'm very confused, the manifest should already be part of the full heartbeat. > > In regards to multiple endpoints, CoAP should does this already, which is analogized best with knocking on someone's door -- it is natural that this spec evolve too ( with backwards compatibility in mind) > > Nonetheless, my only real concern is that prior functionality is also maintained, even if it's not the default to specifically address high latency environment concerns. If @phrocker the manifest would still be part of every heartbeat when "AgentInformation" class is configured in "nifi.c2.root.classes" property. This maintains backward compatibility so the prior functionality is maintained. In the next release, the default class in "nifi.c2.root.classes" will be "AgentInformationWithoutManifest". Haven't looked at CoAP yet for this change. Will look into it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
