bakaid commented on a change in pull request #731: MINIFICPP-1096 fix
BackTrace, OOB indexing, tests, appveyor reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/731#discussion_r385257180
##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -640,10 +637,10 @@ class FileUtils {
std::vector<char> buf(1024U);
while (true) {
ssize_t ret = readlink("/proc/self/exe", buf.data(), buf.size());
- if (ret == -1) {
+ if (ret < 0) {
Review comment:
`readlink`'s contract is pretty clear from the POSIX specification
(https://pubs.opengroup.org/onlinepubs/009695399/functions/readlink.html): it
will return -1 on error, not negative on error. This is fine the way it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
