bakaid commented on a change in pull request #731: MINIFICPP-1096 fix
BackTrace, OOB indexing, tests, appveyor reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/731#discussion_r385771605
##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -112,31 +112,28 @@ class FileUtils {
#endif
}
- static std::string create_temp_directory(char *format) {
+ static std::string create_temp_directory(char * const format) {
Review comment:
I understand your intent, but it can be confusing for users when looking at
the function signature. I agree with making as many things const as possible,
but this, in my opinion, reduces readability of the API without having much
benefit.
None of your references specifically address the case of having const
pointers in function signatures, they are just speaking generically about
immutable objects - and as I said, in the generic case, I agree.
Neither do I know of any major projects that would use const pointers on
their API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
