szaszm commented on a change in pull request #731: MINIFICPP-1096 fix
BackTrace, OOB indexing, tests, appveyor reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/731#discussion_r385681572
##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -640,10 +637,10 @@ class FileUtils {
std::vector<char> buf(1024U);
while (true) {
ssize_t ret = readlink("/proc/self/exe", buf.data(), buf.size());
- if (ret == -1) {
+ if (ret < 0) {
Review comment:
I know, but I feel safer with a `< 0` check before making a narrowing cast
(to unsigned) below. (To avoid unsigned vs signed comparison warnings.)
I can revert if you insist on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
